[PHP 8.4] intl update part 2 #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for #3872 |
Girgias
reviewed
Dec 1, 2024
reference/intl/intlcalendar/set.xml
Outdated
| <entry>8.4.0</entry> | ||
| <entry> | ||
| This had been deprecated in favor of the methods | ||
| <methodname>setDate</methodname> and <methodname>setDateTime</methodname>. |
There was a problem hiding this comment.
Suggested change
| <methodname>setDate</methodname> and <methodname>setDateTime</methodname>. | |
| <methodname>IntlCalendar::setDate</methodname> and | |
| <methodname>IntlCalendar::setDateTime</methodname>. |
Comment on lines
125
to
126
| This had been deprecated in favor of the methods | ||
| <methodname>createFromDate</methodname> and <methodname>createFromDateTime</methodname>. |
There was a problem hiding this comment.
Suggested change
| This had been deprecated in favor of the methods | |
| <methodname>createFromDate</methodname> and <methodname>createFromDateTime</methodname>. | |
| This had been deprecated in favor of the methods | |
| <methodname>IntlGregorianCalendar::createFromDate</methodname> and | |
| <methodname>IntlGregorianCalendar::createFromDateTime</methodname>. |
Comment on lines
111
to
113
| &reftitle.changelog; | ||
| <para> | ||
| <informaltable> |
| <constant>NumberFormatter::ROUND_AWAY_FROM_ZERO</constant> | ||
| </term> | ||
| <listitem> | ||
| <simpara><constant>ROUND_UP</constant> alias.</simpara> |
There was a problem hiding this comment.
Suggested change
| <simpara><constant>ROUND_UP</constant> alias.</simpara> | |
| <simpara> | |
| &Alias; <constant>NumberFormatter::ROUND_UP</constant>. | |
| </simpara> |
| <constant>NumberFormatter::ROUND_TOWARDS_ZERO</constant> | ||
| </term> | ||
| <listitem> | ||
| <simpara><constant>ROUND_DOWN</constant> alias.</simpara> |
Girgias
approved these changes
Dec 2, 2024
kocsismate
reviewed
Dec 2, 2024
| @@ -705,6 +726,15 @@ | |||
| </listitem> | |||
| </varlistentry> | |||
|
|
|||
| <varlistentry xml:id="numberformatter.constants.round-towards-zero"> | |||
| <term> | |||
| <constant>NumberFormatter::ROUND_TOWARDS_ZERO</constant> | |||
There was a problem hiding this comment.
There is no ROUND_TOWARDS_ZERO constant: it is ROUND_TOWARD_ZERO in fact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.