Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] pcntl update part 1 #4208

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[PHP 8.4] pcntl update part 1 #4208

merged 3 commits into from
Dec 2, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen added this to the PHP 8.4 milestone Nov 30, 2024
@devnexen
Copy link
Member Author

for #3872

@devnexen devnexen requested a review from Girgias November 30, 2024 11:42
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the wrapping <para> tags around the `, also it might make sense to have different changelog row for different parameters.

Comment on lines 94 to 125
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
A <classname>ValueError</classname> is thrown if <parameter>signal</parameter>
is empty.
</entry>
</row>
<row>
<entry>8.4.0</entry>
<entry>
A <classname>TypeError</classname> is thrown if <parameter>signal</parameter>
value is not an <type>int</type>.
</entry>
</row>
<row>
<entry>8.4.0</entry>
<entry>
A <classname>ValueError</classname> is thrown if <parameter>signal</parameter>
value is invalid.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indent seems off here?

@Girgias Girgias merged commit 7bc131d into php:master Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants