[PHP 8.4] Add ext-intl constant types
#4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 3, 2024
Comment on lines
+178
to
+183
| <row> | ||
| <entry>8.4.0</entry> | ||
| <entry> | ||
| The class constants are now typed. | ||
| </entry> | ||
| </row> |
There was a problem hiding this comment.
Were the class constant types already documented?
There was a problem hiding this comment.
They were already documented but without the types. However, the classes stubs are already up to date so everything's fine on this side
Girgias
reviewed
Dec 3, 2024
Comment on lines
796
to
797
| <constant>NumberFormatter::PADDING_POSITION</constant> | ||
| <type>int</type> attribute. |
There was a problem hiding this comment.
I went a bit too far with the regex replacement 😄 It's fixed now
Girgias
reviewed
Dec 3, 2024
Comment on lines
705
to
706
| <constant>NumberFormatter::ROUNDING_MODE</constant> | ||
| <type>int</type> attribute. |
Girgias
reviewed
Dec 3, 2024
Girgias
reviewed
Dec 3, 2024
reference/intl/intlchar.xml
Outdated
Comment on lines
4022
to
4025
| <term> | ||
| <constant>IntlChar::UNICODE_VERSION</constant> | ||
| <type>string</type> | ||
| </term> |
alexandre-daubois
force-pushed
the
intl-constants-84
branch
from
6bb9bbf to
8224bfb
Compare
Girgias
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3872