Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate SPL language-snippets and rearrange SPL docs #4286

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 10, 2024

They are only used once, having them as entities is useless.

Leaving this as a draft as I might decide to reorganize SPL first to get rid of the "Miscellaneous" page

@Girgias Girgias force-pushed the spl-entities-integrate branch 2 times, most recently from 9702d19 to 3fbbc35 Compare December 10, 2024 16:37
They are only used once, having them as entities is useless.
Move ArrayObject to data structures, get rid of misc page, do not chunk introduction
@Girgias Girgias force-pushed the spl-entities-integrate branch from 3fbbc35 to e07e84b Compare December 10, 2024 18:38
@Girgias Girgias changed the title Integrate SPL language-snippets Integrate SPL language-snippets and rearrange SPL docs Dec 10, 2024
@Girgias Girgias requested a review from cmb69 December 10, 2024 18:39
@Girgias Girgias marked this pull request as ready for review December 10, 2024 18:39
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Small nit below; otherwise looks good to me (nice to see use-once entities to be removed!)

Co-authored-by: Christoph M. Becker <[email protected]>
@Girgias Girgias merged commit e93feee into php:master Dec 10, 2024
2 checks passed
@Girgias Girgias deleted the spl-entities-integrate branch December 10, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants