Clarify return value of strcmp() and friends (fixes #3629) #4295
+24
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+860
to
+861
| <literal>1</literal> instead. Instead of depending on any concrete | ||
| value, the return value should be compared to <literal>0</literal>. |
There was a problem hiding this comment.
I don't know if that last sentence makes sense. These functions are primarily used in usort. I would either remove that sentence or make it so that it talks about tri-way comparison, less than, greater than and equal to zero.
| @@ -4390,6 +4393,18 @@ local: { | |||
| </para> | |||
| '> | |||
|
|
|||
| <!ENTITY strings.comparison.return ' | |||
| <simpara xmlns="http://docbook.org/ns/docbook"> | |||
| Returns a value less than 0 <parameter>string1</parameter> | |||
There was a problem hiding this comment.
Is this missing "if" or "when"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.