New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust column width in resources.xml for improved layout #4479

Merged

Girgias merged 1 commit into php:master from lufei:fix/4471

Feb 21, 2025

Member

sy-records commented Feb 20, 2025

     <col width="1*"/>
     <col style="width: 1.4*;"/>

Firefox renders the style. But it's an invalid property value in Chrome.

https://github.com/php/phd/blob/3c00a1a7539b660a5d792d4306d4c5a355676eea/phpdotnet/phd/Package/Generic/XHTML.php#L2054-L2063


          Adjust column width in resources.xml for improved layout

885869c

Girgias approved these changes

View reviewed changes

Member

Girgias left a comment

I mean I guess this works, can always alter it later.

Girgias merged commit 8d0b3a6 into php:master

2 checks passed

sy-records deleted the fix/4471 branch

February 21, 2025 20:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet