-
Notifications
You must be signed in to change notification settings - Fork 825
Enable runnable (WASM) examples for datetime #4887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AllenJB
wants to merge
7
commits into
php:master
Choose a base branch
from
AllenJB:wasm_datetime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllenJB
added a commit
to AllenJB/doc-en
that referenced
this pull request
Sep 28, 2025
sy-records
approved these changes
Sep 29, 2025
PhilDaiguille
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4799
Including fixing markup to make sure output replacement works correctly.
Additional changes I made:
?>
(PER coding style, also I see new users using this too often and suspect the manual is partly to blame)The first example on strftime() isn't working. I suspect this is due to the WASM environment not having locales or something. Since the function is deprecated I decided not to both investigating too deeply and just marked it as not runnable.