Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature (#28): Add SolrQuery::setHighlightQuery(string $q) #62

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

omars44
Copy link
Collaborator

@omars44 omars44 commented Jan 9, 2024

Implements #28

@omars44 omars44 requested a review from bix0r January 9, 2024 10:34
Copy link
Collaborator

@bix0r bix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Just add the documentation and change the news entry.

docs/documentation.php Show resolved Hide resolved
NEWS Outdated
@@ -1,3 +1,4 @@
- Add SolrQuery SolrQuery::setHighlightQuery(string $q) (#28)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to mention also getHighlightQuery()

@omars44 omars44 requested a review from bix0r January 10, 2024 14:56
Copy link
Collaborator

@bix0r bix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@omars44 omars44 merged commit e4511fb into master Jan 10, 2024
35 checks passed
@omars44 omars44 deleted the highlight-query branch January 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants