Add a composer.json to enable support for PIE #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bix0r
force-pushed
the
add-pie-support
branch
from
e390d98 to
19b4af4
Compare
|
Hi @bix0r, good to see u're back :) Let's please work on >= PHP 8.1 The rest are EOLed, we shouldn't really spend any efforts there, either we fully support or not fully support. Let's focus our efforts towards the future, I'm happy to have a call about this if needed. |
omars44
requested changes
Dec 8, 2024
composer.json
Outdated
| "license": "PHP-3.01", | ||
| "description": "Apache Solr extension", | ||
| "require": { | ||
| "php": ">= 7.4,<8.5", |
There was a problem hiding this comment.
@omars44 I agree that we should aim to sync with PHP on the versions. At least for this new pie stuff. Perhaps not remove support for old versions in code unless we need to.
I will rebase the packaging PR when this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/php/pie/blob/main/docs/extension-maintainers.md