Intl: Add a new IntlListFormatter class #18519
Conversation
I wouldn't need an RFC if this is a straight forward addition to the existing Intl API which just maps to ICU in a straight forward fashion. I would like to see some smaller improvements, though:
The prefix makes sense to me. Using the |
|
Hi @TimWolla! Thanks for the suggestions - great ideas! I've pushed a commit that makes the class final and enabled those flags. |
Thanks for the quick response! I'll make the changes tomorrow. :) |
|
windows CI failure is related otherwise |
| intl_convert_utf8_to_utf16(&ustr, &ustr_len, ZSTR_VAL(str_val), ZSTR_LEN(str_val), &status); | ||
| if (U_FAILURE(status)) { | ||
| for (uint32_t j = 0; j < i; j++) { | ||
| efree((void *)items[j]); |
There was a problem hiding this comment.
nit: do you get a warning during your build if you remove the (void *) cast ? unsure it s really necessary.
There was a problem hiding this comment.
yep, I get a warning:
/listformatter_class.c:158:17: warning: passing 'const UChar *' (aka 'const unsigned short *') to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
There was a problem hiding this comment.
the const qualifier ... can items just be mutable and eventually doing the cast at ulistfmt_format ?
| $formatter = new IntlListFormatter('ro', IntlListFormatter::TYPE_AND, IntlListFormatter::WIDTH_WIDE); | ||
|
|
||
| try { | ||
| echo $formatter->format([new stdClass()]); |
There was a problem hiding this comment.
nice but would like to see more tests, e.g. an array with a NULL somewhere ... what happens if values are references ? etc..
|
As first round of reviews, look good, I ll play a bit with your branch I think tomorrow. |
| resultLength = ulistfmt_format(LISTFORMATTER_OBJECT(obj), items, itemLengths, count, NULL, 0, &status); | ||
|
|
||
| if (U_FAILURE(status) && status != U_BUFFER_OVERFLOW_ERROR) { | ||
| intl_error_set(NULL, status, "Failed to format list", 0); |
There was a problem hiding this comment.
Need to deal with resources leaks here, might be possible to create a goto label to avoid code repetitions.
So I locally tested, changing unit tests ; looking ok so far. Once all remarks had been addressed, I ll let it rest a bit and come back to it later. |
This PR adds support for ICU's ListFormatter implementation by implementing a new IntlListFormatter class in PHP.
The class supports ANDs, ORs and UNIT format types. However, they are only available if ICU version is 67 or above. On older versions of ICU, we only allow TYPE_AND and WIDTH_WIDE - we need this because, from what I've understood, the minimum version ICU supported is 57, which was bumped from 50 last year.
The class API is pretty simple:
will display
I have some questions here: