ext/oci8: Decrease the reference count before calling zend_list_close()

[SakiTakamachi]

fixes #18873

Since the resource will eventually be freed at the end of the script, this does not result in an actual memory leak, but this change fixes the issue of unnecessary memory usage growth.

[mvorisek]

Thank you a lot for fixing this! ❤

[mvorisek]

I have cherrypicked this into unbundled oci8 ext - php/pecl-database-oci8#32 - and I can confirm this fixes the issue/test.

[nielsdos]

Looks fine, one minor suggestion.
Also: don't we want a test for this? Not that I care too much about this (oracle didn't given the nr of open bugs, so why would I?) but would still be nice I presume.

[nielsdos]

It seems that the original code wanted to call zend_list_delete instead of zend_list_close.
Your fix is fine, but can be improved further by using zend_list_free instead of zend_list_close as we already know the refcount is 0.

[mvorisek]

There are at least 5 other zend_list_close https://github.com/search?q=repo%3Aphp%2Fpecl-database-oci8%20zend_list_close&type=code calls.

[nielsdos]

That code is different.

[SakiTakamachi]

@nielsdos

Thanks! I’ll change it to zend_list_free() and add a test :)

[nielsdos]

The test won't work when ZendMM is disabled, so perhaps it should be skipped in that case but it doesn't hurt running it anyway.
Patch still LGTM

[nielsdos]

There's an easier way, see

php-src/tests/output/gh15179.phpt

Line 9 in 4a98b36

if (getenv("USE_ZEND_ALLOC") === "0") die("skip requires ZendMM");