Add ReflectionProperty::getMangledName()

[alexandre-daubois]

Fix #18605

Good news is that we'll be able to leverage this in the next version of Symfony.

[iluuu1994]

Thank you! The implementation looks correct. You may want to avoid printing the mangled name directly in the test, given that it will make the file appear as a binary file. Maybe print the hex value instead, or replace the special chars (i.e. \0 to \\0).

[alexandre-daubois]

replace the special chars (i.e. \0 to \0)

Nice idea! PR updated, thanks!

[TimWolla]

FWIW: The test format also supports the %0 placeholder for this purpose:

php-src/run-tests.php

Line 2886 in 4a98b36

'%0' => '\x00',

[alexandre-daubois]

I tried to swap for %0 but the tests fail. I can try to spend more time on it if you think it should really be used 🙂 Both ways suit me

[iluuu1994]

Maybe you forgot to switch to EXPECTF?

[alexandre-daubois]

Exactly this 🤦 Thank you!

[iluuu1994]

Thanks! LGTM. Waiting on @DanielEScherzer's review as reflection maintainer.