Skip to content

Fix exception handling in shm_put_var() #19279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Fix exception handling in shm_put_var() #19279

merged 1 commit into from
Jul 29, 2025

Conversation

nielsdos
Copy link
Member

The assertion added in #19177 can hit

@nielsdos nielsdos requested a review from Girgias July 28, 2025 17:25
Girgias
Girgias approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, maybe we should check all the case where php_var_serialize() is called to check they handle a throwing serialization handler correctly?

@nielsdos
Copy link
Member Author

Probably.

@nielsdos nielsdos merged commit 4c576a2 into php:master Jul 29, 2025
9 checks passed
@nielsdos
Copy link
Member Author

Right, maybe we should check all the case where php_var_serialize() is called to check they handle a throwing serialization handler correctly?

There seem to be a few places in ext/spl where it's not checked, but they don't cause side effects and so the VM will handle the exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: sysvshm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias