-
Notifications
You must be signed in to change notification settings - Fork 555
Add API for QA #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add API for QA #1262
Conversation
Would this be an appropriate time/place to consider unifying this API with https://www.php.net/releases/index.php ? (which we use for GA releases) To be clear, I don't have a strong opinion, and will happily consume the data from wherever you want to maintain it, but given there's already an API here I figured I'd raise it just in case it's a helpful reminder. 👍 ❤️ |
@tianon for stable branches, there is https://www.php.net/releases/branches.php endpoint. If it's better to do everything in one place and add, maybe, a filter in the query parameters, let's do that. In any case, I will be glad to hear your opinion. |
Oh, that one's way cleaner than what we use now, which is https://www.php.net/releases/index.php?json&max=100&version=8.4 (replacing 8.4 as appropriate, of course). IMO unifying pre-releases into those APIs makes sense, but I'm not the maintainer, just a humble user. 🙇 ❤️ |
Ah, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but also perhaps add a link to these from /release-candidates.php
's sidebar?
🚀 Regression report for commit f2fb561 is at https://web-php-regression-report-pr-1262.preview.thephp.foundation |
🚀 Preview for commit f2fb561 can be found at https://web-php-pr-1262.preview.thephp.foundation |
releases/release-candidates.php
openapi.yml