Skip to content

Add API for QA #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add API for QA #1262

wants to merge 3 commits into from

Conversation

saundefined
Copy link
Member

@saundefined saundefined commented Apr 24, 2025

  • Add API endpoint releases/release-candidates.php
  • Add schema to openapi.yml

@tianon
Copy link

tianon commented Apr 24, 2025

Would this be an appropriate time/place to consider unifying this API with https://www.php.net/releases/index.php ? (which we use for GA releases)

To be clear, I don't have a strong opinion, and will happily consume the data from wherever you want to maintain it, but given there's already an API here I figured I'd raise it just in case it's a helpful reminder. 👍 ❤️

@saundefined
Copy link
Member Author

@tianon for stable branches, there is https://www.php.net/releases/branches.php endpoint.

If it's better to do everything in one place and add, maybe, a filter in the query parameters, let's do that.
If it's more convenient to have different endpoints - also ok :)

In any case, I will be glad to hear your opinion.

@tianon
Copy link

tianon commented Apr 24, 2025

Oh, that one's way cleaner than what we use now, which is https://www.php.net/releases/index.php?json&max=100&version=8.4 (replacing 8.4 as appropriate, of course). IMO unifying pre-releases into those APIs makes sense, but I'm not the maintainer, just a humble user. 🙇 ❤️

@tianon
Copy link

tianon commented Apr 24, 2025

Ah, branches.php doesn't include the artifact checksums, which we do make use of, but it does include other really useful data like whether a given branch is EOL. 🤔

Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also perhaps add a link to these from /release-candidates.php's sidebar?

@saundefined saundefined marked this pull request as ready for review April 25, 2025 11:49
Copy link
Contributor

github-actions bot commented Apr 25, 2025

🚀 Regression report for commit f2fb561 is at https://web-php-regression-report-pr-1262.preview.thephp.foundation

Copy link
Contributor

🚀 Preview for commit f2fb561 can be found at https://web-php-pr-1262.preview.thephp.foundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants