Add redirect for reserved keywords #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
changed the title
| 'use' => 'language.namespaces.php', | ||
| 'void' => 'language.types.void.php', | ||
| 'xor' => 'language.operators.logical.php', | ||
| 'yield from' => 'language.generators.syntax.php#control-structures.yield.from', |
There was a problem hiding this comment.
Are spaces allowed in this context?
There was a problem hiding this comment.
Yes. You can test this by visiting http://localhost:8080/yield%20from and http://localhost:8080/yield+from when running the code in 'local development' mode according to the documentation in the read-me file at the root of this repository. (ie, php -S localhost:8080 .router.php)
derickr
added a commit
that referenced
this pull request
Nov 29, 2023
|
Merged after a rebase, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing to https://php.net/yield recently, I was surprised to see a message saying that "yield doesn't exist". The
yieldkeyword does exist, but doesn't have a dedicated page so hasn't been indexed. This pull request adds a special case for this keyword so that it can be found by users.I've also looked into how to get all keywords declared automatically. The best I can come up with today (without significant changes to how the search / look-up process works) is over on the 'systems' repository: php/systems#19
Update: I've now gone through all the reserved words listed on https://php.net/reserved and added these to this pull request.