Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not pass null to function that expects string #901

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 15, 2023

This pull request

  • stops passing null to a function that expects string

Spotted in #900.

πŸ’β€β™‚οΈ In the first iteration of the inner foreach-loop, $version is null:

$version = null;
$current = null;
foreach ($RELEASES as $versions) {
foreach ($versions as $ver => $info) {
if (version_compare($ver, $version) > 0) {

Copy link

πŸš€ Deployed on https://web-php-pr-901.preview.thephp.foundation

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 026b509 into php:master Feb 12, 2024
3 checks passed
@localheinz localheinz deleted the fix/null branch February 12, 2024 17:18
@localheinz
Copy link
Contributor Author

Thank you, @saundefined!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants