Skip to content

Do not call Reflection*::setAccessible() in PHP >= 8.1 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Aug 1, 2025

As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default.

(https://www.php.net/manual/en/reflectionmethod.setaccessible.php and https://www.php.net/manual/en/reflectionproperty.setaccessible.php).

There're even plans to deprecate the method in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations

@jaapio jaapio merged commit 94f8051 into phpDocumentor:5.x Aug 1, 2025
42 of 43 checks passed
@jaapio
Copy link
Member

jaapio commented Aug 1, 2025

Thanks for fixing this!

@W0rma W0rma deleted the reflection-set-accessible branch August 1, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants