ISSUE-338: saml login #1064
Open
ISSUE-338: saml login #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramley
reviewed
Jan 22, 2025
There was a problem hiding this comment.
The problem with divide by 0 for the Last Campaign statistics has already been fixed in the bootlist theme phpList/phplist-ui-bootlist@8c72c07
Not sure that I understand when the file home.php in the admin directory is used instead of home.php in the theme.
bramley
reviewed
Jan 22, 2025
public_html/lists/admin/login.php
Outdated
| @@ -43,6 +43,9 @@ function footer() | |||
| echo $GLOBALS['I18N']->get('Enter your email address').': </p><input type="text" name="forgotpassword" value="" size="30" />'; | |||
| echo ' <input class="submit" type="submit" name="process" value="'.$GLOBALS['I18N']->get('Send password').'" />'; | |||
| echo ' <div class="clear"></div>'; | |||
| if ($GLOBALS['plugins']['simplesaml']) { | |||
There was a problem hiding this comment.
This should probably be
array_key_exists('simplesaml', $plugins)
or
isset($plugins['simplesaml'])
because it usually won't exist.
TatevikGr
force-pushed
the
ISSUE-338
branch
3 times, most recently
from
cf0a666 to
e00f560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adopt for simplesaml plugin
fix division by 0 error
Contributor License Agreement
Related Issue
phpList/phplist-plugin-saml2#4
Screenshots (if appropriate):