Allow selecting forums in addition to Index and Everywhere

[iMattPro]

No description provided.

[rxu]

How does {% set ... in ... %} construction work? Couldn't find it in docs.

[iMattPro]

set defines a new variable. https://twig.symfony.com/doc/2.x/tags/set.html
in is like in array https://twig.symfony.com/doc/2.x/templates.html#containment-operator

This is creating a boolean variable: true if index is in the array of locations, false if not

[rxu]

Yeah, I see what do they mean individually but just curious how would it work together. So it adds has_index element into ba.LOCATIONS array?

[iMattPro]

No it creates a new twig template variable called has_index that is true when ba.LOCATIONS contains -1 which is then used in the next few lines

[iMattPro]

it's same as doing:

$has_index = in_array(ext::INDEX_ONLY, $locations);

[rxu]

There's an issue with announcements dismission (probably intended but not sure, also don't know if it was the case before).
If you have an announcement available for everyone and dismimm it as a guest, then if you log in with the same browser, the announcement is also dismissed for registered user. And vice versa.

[rxu]

Same applies to registered users: if user1 has dismissed the announcement, it's gonna be dismissed for any registered user on the same device and browser.

[iMattPro]

That's how it always worked. It uses a cookie and a database entry if you were logged in.

User1 dismisses, it's gone for them forever. Even if they log out it's still gone because of cookies.

If a guest dismisses it's gone for that user on that device as long as the cookie doesn't expire.

[rxu]

May be add user_id to cookie to distinct users dismission?

[iMattPro]

The cookie is to handle ANONYMOUS users

[rxu]

Then it shouldn't affect registered users, should it? But it does. Or does registered users dismission uses both cookie and DB part? Or am I missing the whole point?

[iMattPro]

if a user closes an announcement, it never even gets queried again for them. so the cookie only affects them after they log out. if they switch to another account the cookie will keep it closed, but in what use case do different people use the same forum on the same device?