User config and profiling #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dantleech
commented
Dec 19, 2014
dantleech
commented
- Enable setting expansion for timings
- Enableable timing for query / traversal
- Config is automatically based with dist config
There was a problem hiding this comment.
Should probably use the stopwatch component if I do much more of this.
There was a problem hiding this comment.
i would leave it as is for now and add StopWatch if you have more cases.
dantleech
force-pushed
the
config_exutiontime
branch
3 times, most recently
from
af35888 to
79996c8
Compare
There was a problem hiding this comment.
could it make sense to use OptionsResolver instead of this class? the cool thing about it is that you get validation and defaults handling for free.
There was a problem hiding this comment.
I think I would still need this class to represent the instance of the configuration, but yeah we could integrate the OptionResolver
tbh the current config system is still a bit messy/strange and could use a general refactor.
dantleech
force-pushed
the
config_exutiontime
branch
from
79996c8 to
a4ef324
Compare
- Enable setting expansion for timings - Enableable timing for query / traversal - Config is automatically based with dist config
dantleech
force-pushed
the
config_exutiontime
branch
from
a4ef324 to
3890629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.