Add color on phpcsfixer

[oallain]

Q	A
Branch	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Documented?	no
Fixed tickets

Hello,
A picture is worth a thousand words, I let you see the result, which is so much more pleasant.

Before

After

The inspiration comes from ECS.

grumphp/src/Task/Ecs.php

Line 71 in 3ec61c1

$arguments->addOptionalArgument('--ansi', true);

[yguedidi]

I think this task is using a dedicated formatter (GrumPHP\Formatter\PhpCsFixerFormatter), that this change will break

[veewee]

Indeed, this will bypass the custom formatter.
However, the formatter is quite old and was used to propose a way of fixing the code.
Now that we have our fixer configuration - which used the process to build de fixer process - it seems safe to nuke that custom formatter. It doesn't really provide any benefits anymore + it seems better to rely on the official php-cs-fixer formatters.

@oallain : Can you:

• remove the custom formatter and it's implementation
• provide a configurable format string option with a default of txt
• add documentation for these options?

Do we need to specify --ansi?
Normally the system is smart enough to detect ansi or not.

[oallain]

Hello @veewee

I tried to do what you asked.
Tell me if I've forgotten or misunderstood anything.

As for the "--ansi" yes, if not, it doesn't work.

[veewee]

@oallain

I tried to do what you asked. Tell me if I've forgotten or misunderstood anything.>

I probably did not describe it well enough :)
Currently the task relies on PhpCsFixerFormatter. This one basically requires the format to be JSON in order to work.
If it's not, it falls back to the raw value - which might work in your text case.

However, I don't think we need the custom PhpCsFixerFormatter anymore.
That one was introduces to suggest the fix command.
Since we introduced a Fixer based on a Process command, I don't think we need that custom formatter anymore.

Instead we could use the raw php-cs-fixer output and print the additionel Process arguments as string in case of failure.

Hope this makes it a bit more clear. Feel free to ask questions if not :)

[veewee]

We notices this PR became inactive. If you wish to continue, feel free to pick it up again.
If not, we will be closing this PR soon. Thanks for your understanding.