Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --skip-property-types of ValidateSchemaCommand #1145

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

wucdbm
Copy link
Contributor

@wucdbm wucdbm commented Jul 5, 2024

Doctrine seems to have added property types validation in the aforementioned command This will allow passing the skip property types option where making changes to that is undesirable

Q A
Branch v2.x (Or, IDK?)
Bug fix? no
New feature? yes
BC breaks? no Because the current behaviour is property types are validated depending on your ORM version, this only allows switching that off
Deprecations? no
Documented? yes
Fixed tickets -

There seems to be an option skip-property-types in Doctrine's ValidateSchemaCommand which can't be turned off and so always blows up on my on-commit hook and is something I can't/won't fix in my project, but I'd still like the rest of what ValidateSchemaCommand does. I guess that's an issue with other people as well.

PS Added a test case, please review though

wucdbm and others added 2 commits July 5, 2024 21:00
Doctrine seems to have added property types validation in the aforementioned command
This will allow passing the skip property types option where making changes to that is undesirable
@veewee veewee added this to the 2.7.0 milestone Jul 11, 2024
@veewee veewee merged commit b3986f0 into phpro:v2.x Jul 11, 2024
20 checks passed
@veewee
Copy link
Contributor

veewee commented Jul 11, 2024

Looks good, Thanks!

@wucdbm
Copy link
Contributor Author

wucdbm commented Aug 18, 2024

@veewee Um, would you consider releasing this one, seeing as the other PR in the milestone is sort of dead for a while

I am currently stuck to the commit hash, so I wouldn't get any patch releases and/or bugfixes

@veewee
Copy link
Contributor

veewee commented Aug 22, 2024

@wucdbm Tagged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants