Add allow-list functionality to securitychecker_enlightn #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjaap
commented
Nov 19, 2024
peterjaap
commented
| Q | A |
|---|---|
| Branch | v2.x |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Documented? | yes |
veewee
requested changes
Nov 26, 2024
|
@veewee I've added a test case and used |
veewee
requested changes
Dec 3, 2024
| @@ -50,6 +52,7 @@ public function run(ContextInterface $context): TaskResultInterface | |||
| $arguments = $this->processBuilder->createArgumentsForCommand('security-checker'); | |||
| $arguments->add('security:check'); | |||
| $arguments->addOptionalArgument('%s', $config['lockfile']); | |||
| $arguments->addArgumentArrayWithSeparatedValue('--allow-list', $config['allow_list'] ?? []); | |||
There was a problem hiding this comment.
allow_list is not nullable since it has a default of []
| [ | ||
| 'security:check', | ||
| './composer.lock', | ||
| '--allow-list=allow_advisory_1,allow_advisory_2' |
There was a problem hiding this comment.
This is not how addArgumentArrayWithSeparatedValue works.
If you want this output, you could use something like:
addOptionalCommaSeparatedArgument('--allow-list=%s', $config['allow_list']);| @@ -19,6 +19,10 @@ grumphp: | |||
| securitychecker_enlightn: | |||
| lockfile: ./composer.lock | |||
| run_always: false | |||
| allow_list: | |||
There was a problem hiding this comment.
This configuraiton option should be explained in more details underneath.
| @@ -24,10 +24,12 @@ public static function getConfigurableOptions(): ConfigOptionsResolver | |||
| $resolver->setDefaults([ | |||
| 'lockfile' => './composer.lock', | |||
| 'run_always' => false, | |||
| 'allow_list' => [] | |||
There was a problem hiding this comment.
The method provideConfigurableOptions in the test should be altered to cover this newly added default.
|
@peterjaap nice addition. This is something i could use as well. Thanks for adding it. When will you have time to look at the changes needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.