Merge pull request #6 from bona-kim/replace-htags-with-ptags

replace h tags with p tags
phpro · Mar 10, 2022 · 0e62a2d · 0e62a2d
2 parents 038255f + ba24296
commit 0e62a2d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## [2.0.4]
+* Replace H3 tags with P tags
 * Update toggle slider status after visitors accept all cookies.
 
 ## [2.0.3]

diff --git a/view/frontend/templates/modal/preferences.phtml b/view/frontend/templates/modal/preferences.phtml
@@ -22,13 +22,13 @@ $cookieGroups = $viewModel->getCookieGroups();
         </div>
         <div class="consent-tabs-content">
             <div class="consent-tab-content cookie-policy">
-                <h3><?= __('Cookie Policy') ?></h3>
+                <p class="title"><?= __('Cookie Policy') ?></p>
                 <?= $this->getLayout()->createBlock(\Magento\Cms\Block\Block::class)->setBlockId($viewModel->getCookiePolicyIdentifier())->toHtml();?>
             </div>
             <?php  foreach ($cookieGroups as $cookieGroup ) : ?>
                 <?php if ($cookieGroup->isActive()): ?>
                     <div class="consent-tab-content <?= $cookieGroup->getSystemName() ?>">
-                        <h3><?= $cookieGroup->getName() ?></h3>
+                        <p class="title"><?= $cookieGroup->getName() ?></p>
                         <p><?= $cookieGroup->getDescription() ?></p>
                         <div class="cookie-toggle-wrapper">
                             <label class="cookie-toggle">
@@ -40,7 +40,7 @@ $cookieGroups = $viewModel->getCookieGroups();
                 <?php endif; ?>
             <?php endforeach; ?>
             <div class="consent-tab-content privacy-policy">
-                <h3><?= __('Privacy Policy') ?></h3>
+                <p class="title"><?= __('Privacy Policy') ?></p>
                 <?= $this->getLayout()->createBlock(\Magento\Cms\Block\Block::class)->setBlockId($viewModel->getPrivacyPolicyIdentifier())->toHtml();?>
             </div>
         </div>

diff --git a/view/frontend/templates/widget/overview.phtml b/view/frontend/templates/widget/overview.phtml
@@ -4,7 +4,7 @@ $cookieGroups = $block->getCookieGroups();
 ?>
 <div class="cookie-consent-overview">
     <?php foreach ($cookieGroups as $cookieGroup): ?>
-        <h3><?= $cookieGroup->getName() ?></h3>
+        <p class="title"><?= $cookieGroup->getName() ?></p>
         <div class="cookie-group-description">
             <p><?= $cookieGroup->getDescription() ?></p>
         </div>

diff --git a/view/frontend/web/css/source/_module.less b/view/frontend/web/css/source/_module.less
@@ -90,8 +90,9 @@
               .consent-tab-content {
                 position: relative;
 
-                h3 {
+                p.title {
                   margin-bottom: 20px;
+                  font-size: @font-size___l;
                 }
 
                 .cookie-toggle-wrapper {
@@ -171,7 +172,7 @@
   //  Cookie overview widget
   //  ---------------------------------------------
   .cookie-consent-overview {
-    h3 {
+    p.title {
       margin-bottom: 20px;
     }