Skip to content

Commit

Permalink
PHPRO-415 Fix faulty docs
Browse files Browse the repository at this point in the history
  • Loading branch information
BrentRobert committed Jul 2, 2024
1 parent 08c61a2 commit d81aeba
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .php-cs-fixer.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
'strict_param' => true,
'array_indentation' => true,
'compact_nullable_typehint' => true,
'fully_qualified_strict_types' => true,
'fully_qualified_strict_types' => false,
])
->setFinder($finder);

4 changes: 2 additions & 2 deletions Api/Data/TranslationInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ public function setFrontend($frontend);
/**
* Retrieve existing extension attributes object or create a new one.
*
* @return TranslationExtensionInterface|null
* @return \Phpro\Translations\Api\Data\TranslationExtensionInterface|null
*/
public function getExtensionAttributes();

/**
* Set an extension attributes object.
*
* @param TranslationExtensionInterface $extensionAttributes
* @param \Phpro\Translations\Api\Data\TranslationExtensionInterface $extensionAttributes
* @return $this
*/
public function setExtensionAttributes(
Expand Down
10 changes: 5 additions & 5 deletions Api/TranslationRepositoryInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ interface TranslationRepositoryInterface
/**
* Save Translation
*
* @param Data\TranslationInterface $translation
* @param \Phpro\Translations\Api\Data\TranslationInterface $translation
* @throws \Magento\Framework\Exception\LocalizedException
* @return Data\TranslationInterface
* @return \Phpro\Translations\Api\Data\TranslationInterface
*/
public function save(
Data\TranslationInterface $translation
Expand All @@ -24,16 +24,16 @@ public function save(
*
* @param string $translationId
* @throws \Magento\Framework\Exception\LocalizedException
* @return Data\TranslationInterface
* @return \Phpro\Translations\Api\Data\TranslationInterface
*/
public function getById($translationId);

/**
* Retrieve Translation matching the specified criteria.
*
* @param SearchCriteriaInterface $searchCriteria
* @param \Magento\Framework\Api\SearchCriteriaInterface $searchCriteria
* @throws \Magento\Framework\Exception\LocalizedException
* @return Data\TranslationSearchResultsInterface
* @return \Phpro\Translations\Api\Data\TranslationSearchResultsInterface
*/
public function getList(
SearchCriteriaInterface $searchCriteria
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@
### Bugfix
- Fix return types console commands
- Locales are not found if set in env.php and not in core_config_table

## [1.4.1] - 2024-07-02
### Bugfix
- Fix faulty doc blocs preventing di:compile
8 changes: 0 additions & 8 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,5 @@
"magento/composer-dependency-version-audit-plugin": true,
"dealerdirect/phpcodesniffer-composer-installer": true
}
},
"scripts": {
"post-install-cmd": [
"([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../magento/php-compatibility-fork)"
],
"post-update-cmd": [
"([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../magento/php-compatibility-fork)"
]
}
}

0 comments on commit d81aeba

Please sign in to comment.