-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConstantArrayType: fix returned ConstantArrayTypeAndMethod #3372
ConstantArrayType: fix returned ConstantArrayTypeAndMethod #3372
Conversation
Is missing a test |
I'm not sure if there is any native functionality to test against. I need this function for proper dead-code analysis. |
If nothing else is possible then we need a unit test in ConstantArrayTypeTest. Make sure to initialize |
c19e56a
to
dd1184a
Compare
|
||
$this->assertCount(1, $classStringResult); | ||
$this->assertCount(1, $objectResult); | ||
$this->assertInstanceOf(ConstantStringType::class, $classStringResult[0]->getType()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the fix, this is still just ObjectType
here.
Added a test and rebased on top of 2.0.x |
Thank you. |
I'm sorry, had to revert this. There are regressions (could be seen in the issue bot): |
With this, we can recognize those cases: