More precise array_keys return type
#3590
Conversation
| if (!$keysArray->isConstantArray()->no()) { | ||
| $newArrayType = new ArrayType( | ||
| $keysArray->getIterableKeyType()->generalize(GeneralizePrecision::lessSpecific()), | ||
| $keysArray->getIterableValueType()->generalize(GeneralizePrecision::lessSpecific()), | ||
| ); | ||
| } |
There was a problem hiding this comment.
we could make this more sophisticated and support more filtering on constant array, but I think this is good enough for now.
until a few days ago I didn't even know array_keys can filter by values - it feels pretty rare
There was a problem hiding this comment.
I think the diff makes sense, but don't get me wrong, just curious, currently this PR does effectively not change much of the behaviour, right? at least it does not use the new filter or strict arg, or am I missing something? It could be added in a follow-up, sure, but if that's also not the plan, than this only adds some list type to the result, or am I wrong?
|
This pull request has been marked as ready for review. |
|
Just wondering if any of this could also be done inside See also #2117 where I played around with adding filter support 😊 |
|
Nice, sorry, noticed too late and should have mentioned it earlier. Later on, e.g. in #3514 I used |
|
I used $strict as bool, because other methods in Type also use it. Do you see a use-case where Trinary would come in handy? |
|
Not necessarily. If others use that too, then consistency makes sense IMO. |
staabm
force-pushed
the
b11928
branch
3 times, most recently
from
21fc500 to
c16ce86
Compare
src/Type/Type.php
Outdated
| @@ -134,7 +134,7 @@ public function setExistingOffsetValueType(Type $offsetType, Type $valueType): T | |||
|
|
|||
| public function unsetOffset(Type $offsetType): Type; | |||
|
|
|||
| public function getKeysArray(): Type; | |||
| public function getKeysArray(?Type $filterValueType = null, bool $strict = false): Type; | |||
There was a problem hiding this comment.
- This a BC break
- I don't like optional parameters at all.
The solution is to add another method that you'll use in the places where you're passing in the parameters now.
staabm
force-pushed
the
b11928
branch
3 times, most recently
from
656e6e2 to
05c0c60
Compare
| @@ -0,0 +1,51 @@ | |||
| <?php | |||
|
|
|||
| namespace Bug11928; | |||
There was a problem hiding this comment.
staabm
force-pushed
the
b11928
branch
2 times, most recently
from
470e444 to
dcdcc5a
Compare
closes phpstan/phpstan#11928