Make DOMNamedNodeMap generic #4211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanfisk
force-pushed
the
issue/13365
branch
5 times, most recently
from
470e9bb to
260df38
Compare
| * @property-read int $length | ||
| */ | ||
| class DOMNamedNodeMap | ||
| class DOMNamedNodeMap implements Traversable, IteratorAggregate, Countable |
There was a problem hiding this comment.
It shouldn't need to implements both Traversable and IteratorAggregate in the stub.
There was a problem hiding this comment.
@VincentLanglet I just copied it from DOMNodeList at
Line 75 in c0e6f0e
Do you want me to fix DOMNodeList as well?
There was a problem hiding this comment.
If it's done this way for DOMNodeList you can just ignore my remark I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#13365.