Dev #112
Dev #112
Conversation
|
is there an issue with my pull request? |
|
Sorry, I'm reviewing it right now. |
| || $this->post->depicao == '' || $this->post->arricao == '' | ||
| || $this->post->aircraft == '' || $this->post->flighttime == '' | ||
| public function edit_pirep_post($postData = null) { | ||
| $postData = ($postData == null) ? $this->post : $postData; |
There was a problem hiding this comment.
Why the change to $postData from $this->post?
There was a problem hiding this comment.
I believe this was done during a mass find/replace. It's been a while but I don't believe it changed functionality. Had more to do with keeping things uniform
There was a problem hiding this comment.
Ah! I remember, I added a default parameter, so this could be called from another function without using the Vars class. Adding API functionality and all that jazz.
|
And the verdict is?... |
|
nshahzad, Sincere, RobB |
|
Hi @Oxymoron290, sorry for the super long delay. Are these commits still OK to merge in? |
|
Yes, ensure the last commit is 775625b as it was a conflict resolution. No worries on the delay, we all have priorities. |
|
I made a couple of comments, if you can look at those, I will merge it. Thanks! |
Resolution for issue #5
Resolution for issue #110
Resolution for issue #111