Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings from external repositories if possible #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021, 2022, 2023 Google LLC
# Copyright 2021, 2022, 2023, 2024 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -12,6 +12,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.

common --enable_platform_specific_config

# Suppress warnings from external repositories if possible.
build --features=external_include_paths
build --host_features=external_include_paths

# FIXME: This shouldn’t be necessary. File bug against Bazel.
build:windows --copt='/external:W3' --host_copt='/external:W3'

# Run Pylint by default.
build --aspects='//private:defs.bzl%check_python'
build --output_groups='+check_python'
Expand Down
2 changes: 1 addition & 1 deletion emacs/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,4 @@ def _install(ctx, cc_toolchain, readme):

def _munge_msvc_flag(s):
# Crude way to work around specifying Visual C++ options in .bazelrc.
return s.replace("/std:c", "-std=gnu")
return None if s.startswith("/external:") else s.replace("/std:c", "-std=gnu")
Loading