-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade base image to phusion/baseimage:noble-1.0.0 #413
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d5331ef
Upgrade image base to phusion/baseimage:noble-1.0.0
ajhodgson c3f5715
Only create dir if not already present
ajhodgson 8c12e01
Explicitly install ncurses for CRuby<3.3
ajhodgson d5ebc9d
Move error_log definition to root scope.
ajhodgson ce283d3
Allow setting http_proxy via EXTRA_BUILD_ARGS to cache apt packages
ajhodgson dad000e
Reflect Redis upgrade
ajhodgson 32f28b3
Update changelog regarding available python versions
ajhodgson 8c7244c
Merge master
ajhodgson e8c31a8
Merge branch 'master' into ajhodgson/upgrade-to-noble
CamJN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ MAINTAINER Phusion <[email protected]> | |
ADD . /pd_build | ||
|
||
ARG ARCH | ||
ARG http_proxy | ||
RUN --mount=type=cache,target=/build_cache \ | ||
/usr/bin/nice /pd_build/install_image.sh | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
# syntax=docker/dockerfile:1.2 | ||
FROM phusion/baseimage:jammy-1.0.4 | ||
FROM phusion/baseimage:noble-1.0.0 | ||
MAINTAINER Phusion <[email protected]> | ||
|
||
ADD . /pd_build | ||
|
||
ARG ARCH | ||
ARG http_proxy | ||
RUN --mount=type=cache,target=/build_cache \ | ||
rm -rf "/build_cache/${ARCH}" && \ | ||
/usr/bin/nice /pd_build/install_base.sh && \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it falling back to STDOUT by default ? why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still sets error_log /var/log/nginx/error.log; - it just does it at the root scope now.
You can look at phusion/passenger#2541 for why.
There is no change in behaviour here.