Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent phylorefs from being modified by being opened by the Specifier component #314

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Jan 3, 2024

WIP: I could try to create a complicated normalization method here in Klados, but the right way to do this is probably to do this piece-by-piece in phyx.js -- so that the PhyxWrapper tells the PhylogenyWrapper and PhylorefWrapper to wrap their respective objects, and so on down the line. This is being tracked there as phyloref/phyx.js#134.

Should fix #263.

A better way to fix this would be in phyx.js.
@gaurav gaurav force-pushed the prevent-modification-of-phylorefs branch from 3c56c21 to db5d5e3 Compare April 24, 2024 05:23
@gaurav
Copy link
Member Author

gaurav commented Jun 19, 2024

  • Make collapsed form non-editable and replace the "Expand" button with an "Expand/Edit" button or two buttons that do the same thing. Note that the edit button could be an icon rather than a full button.
  • Change the logic: don't update the verbatim specifier, but do update the binomial/genus/specific epithet/infraspecific epithet if any of them change. That should get rid of this issue.
  • If the file is missing details (e.g. no infraspecific epithet), which the tool fills in when you load the file.
    • We could highlight the specific modified field to indicate to the user that something here has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simply opening a phyloreference marks it as modified
1 participant