Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve yarn v1 parser #1304

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Improve yarn v1 parser #1304

merged 3 commits into from
Nov 27, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Nov 23, 2023

This fixes multiple issues in the v1 yarn parser:

  • Add support for path dependencies
  • Add support for git:// dependencies
  • Fix aliased dependencies
  • Ignore http(s) dependencies

Closes #1299.

@cd-work
Improve yarn v1 parser
ac362f9 
This fixes multiple issues in the v1 yarn parser:
 - Add support for path dependencies
 - Add support for git:// dependencies
 - Fix aliased dependencies
 - Ignore http(s) dependencies

Closes #1299.
@cd-work cd-work requested a review from a team as a code owner November 23, 2023 18:30
mathew-horner
mathew-horner reviewed Nov 27, 2023
View reviewed changes
lockfile/src/parsers/yarn.rs Outdated Show resolved Hide resolved
lockfile/src/javascript.rs Show resolved Hide resolved
lockfile/src/parsers/yarn.rs Show resolved Hide resolved
lockfile/src/parsers/yarn.rs Outdated Show resolved Hide resolved
lockfile/src/parsers/yarn.rs Show resolved Hide resolved
maxrake
maxrake requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code was minimally reviewed. The updated tests are great...and passing in CI to help reassure of the correctness of the changes.

A CHANGELOG update is needed.

@cd-work cd-work requested a review from maxrake November 27, 2023 22:47
@cd-work cd-work merged commit 7a5c03a into main Nov 27, 2023
13 checks passed
@cd-work cd-work deleted the yarnv1_renames branch November 27, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-horner mathew-horner mathew-horner approved these changes

@maxrake maxrake maxrake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yarn v1 renamed dependencies not handled correctly
3 participants
@cd-work @maxrake @mathew-horner