Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions API #407

Merged
merged 66 commits into from
Jun 16, 2022
Merged

Extensions API #407

merged 66 commits into from
Jun 16, 2022

Conversation

andreaphylum
Copy link
Contributor

Closes #390, blocked by #353.

The functions in api.rs are to be exposed by Deno. There is a mechanism for lazily evaluating common dependencies that are internal implementation details (currently: Config and PhylumApi).

andreaphylum and others added 29 commits May 2, 2022 19:46
@andreaphylum
Extensions subcommand entry points
d53d74e
@andreaphylum
Construct extension from path (with manifest)
29e0323
@andreaphylum
Install and load methods for Extension
d7d53e4
@andreaphylum
Acceptance criteria tests
596f7e7
@andreaphylum
Acceptance criteria tests
2e3fe42
@andreaphylum
Acceptance criteria tests
e0b2d17
@andreaphylum
Extensions base documentation
5bd4ec8
@andreaphylum
Clippy lints, conditional compilation fix for compiling with no features
3f059a3
@andreaphylum
Cargo fmt
e54eddc
@andreaphylum @kylewillmon
Update cli/Cargo.toml
a13e64b 
Co-authored-by: Kyle Willmon <[email protected]>
@andreaphylum @kylewillmon
Update cli/src/commands/extensions/mod.rs
5f5105c 
Co-authored-by: Kyle Willmon <[email protected]>
@andreaphylum
Review fixes
3140baf
@andreaphylum
Merge branch 'andrea/extensions-install-mgmt' of github.com:phylum-de…
9e7412d 
…v/cli into andrea/extensions-install-mgmt
@andreaphylum
Review fixes
aa4adc2
@andreaphylum
Merge branch 'main' of github.com:phylum-dev/cli into andrea/extensio…
3817764 
…ns-install-mgmt
@andreaphylum
Documentation with new format
5ee23e7
@andreaphylum
Env var cleanup skip; cargo fmt
88d23d4
@andreaphylum
Merge branch 'main' of github.com:phylum-dev/cli into andrea/extensio…
a7b0342 
…ns-install-mgmt
@andreaphylum
Anyhow error simplification
df7fac2
@andreaphylum
Lints and cargo alias
3ad428b
@andreaphylum
Phylum Analyze extension API draft
2eb4f4c
@andreaphylum
Extensions API functions
29703e9
@andreaphylum
Cargo fmt
bf2b1dd
@andreaphylum @kylewillmon
Apply suggestions from code review
6e0f5cb 
Co-authored-by: Kyle Willmon <[email protected]>
@andreaphylum
More code review fixes
ba7ac03
@andreaphylum
Merge branch 'main' into andrea/extensions-install-mgmt
6749307
@andreaphylum
Fix typo
6dc926b
@andreaphylum
Merge branch 'andrea/extensions-install-mgmt' of github.com:phylum-de…
35bfa96 
…v/cli into andrea/extensions-api
@andreaphylum
Injected dependencies and deno_core::OpState support
211b99e
@andreaphylum andreaphylum requested a review from a team May 23, 2022 17:05
cd-work
cd-work requested changes Jun 8, 2022
View reviewed changes
cli/tests/fixtures/extensions/api-extension/phylum-api.ts Show resolved Hide resolved
cli/tests/extensions.rs Outdated Show resolved Hide resolved
cli/tests/fixtures/extensions/api-extension/main.ts Show resolved Hide resolved
cli/tests/fixtures/extensions/api-extension/main.ts Show resolved Hide resolved
cli/tests/fixtures/extensions/api-extension/PhylumExt.toml Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
@kylewillmon kylewillmon mentioned this pull request Jun 9, 2022
Open
cd-work
cd-work requested changes Jun 10, 2022
View reviewed changes
cli/src/commands/extensions/mod.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/deno.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/commands/extensions/api.rs Show resolved Hide resolved
@andreaphylum andreaphylum requested a review from cd-work June 13, 2022 13:24
cd-work
cd-work requested changes Jun 13, 2022
View reviewed changes
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cd-work
cd-work previously approved these changes Jun 13, 2022
View reviewed changes
cd-work
cd-work previously approved these changes Jun 13, 2022
View reviewed changes
kylewillmon
kylewillmon previously approved these changes Jun 15, 2022
View reviewed changes
cli/src/commands/extensions/api.rs Outdated Show resolved Hide resolved
cli/src/lockfiles/mod.rs Outdated Show resolved Hide resolved
@andreaphylum andreaphylum dismissed stale reviews from kylewillmon and cd-work via ef38455 June 15, 2022 17:15
@andreaphylum andreaphylum merged commit a60bdaf into main Jun 16, 2022
@andreaphylum andreaphylum deleted the andrea/extensions-api branch June 16, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cd-work cd-work cd-work approved these changes

@kylewillmon kylewillmon kylewillmon approved these changes

@samtay samtay Awaiting requested review from samtay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extensions API
4 participants
@andreaphylum @maxrake @kylewillmon @cd-work