ci: ensure tags are fetched in submodule update workflow #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrake
requested review from
kylewillmon and
cd-work
and removed request for
texasbeef45 and
joephylum
cd-work
requested changes
Feb 1, 2024
cd-work
approved these changes
Feb 1, 2024
maxrake
added a commit
that referenced
this pull request
Feb 2, 2024
The change in #97 was not the solution as manual trigger to the updated workflow resulted in the same error. Further investigation revealed that the submodule was not updated (did not have the latest commits and tags) before the workflow attempted to checkout the newly created tag. This change accounts for that update step. It also ensures that each submodule command in the workflow and in documentation is acting on the explicitly named submodule so that other submodules (which don't exist yet but may soon) are not accidentally changed/updated. Finally, the `actions/checkout` option to `fetch-tags` was removed since it was determined to act on the `documentation` repo itself and not any of the submodules. The `documentation` repo does not have any tags and even if it did we don't need them for the submodule update workflow.
maxrake
added a commit
that referenced
this pull request
Feb 6, 2024
The change in #97 was not the solution as a manual trigger to the updated workflow resulted in the same error. Further investigation revealed that the submodule was not updated (did not have the latest commits and tags) before the workflow attempted to checkout the newly created tag. This change accounts for that update step. It also ensures that each submodule command in the workflow and in documentation is acting on the explicitly named submodule so that other submodules (which don't exist yet but may soon) are not accidentally changed/updated. Finally, the `actions/checkout` option to `fetch-tags` was removed since it was determined to act on the `documentation` repo itself and not any of the submodules. The `documentation` repo does not have any tags and, even if it did, they aren't needed for the submodule update workflow. --------- Co-authored-by: Kyle Willmon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix the error seen during the latest
CLI release, which triggered a submodule update in this
repository. That failed
in what appears to be an inability to access the requested
submodule tag. The
actions/checkoutaction does not fetchsubmodules or tags by default.