Minor fixes #6
Open
Minor fixes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it gets written to stdout and breaks everything
maxrake
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I got my new computer I migrated my Git projects over using Git and the workareas all got cleaned. This PR fixes (most of) problems I encountered while getting this running again.
The Sonatype Java library wasn't set up correctly as a submodule so it wasn't getting checked out.
packageurl-js has changed a lot since the previous released version so I updated its code.
I must be using a new version of PHP I started getting deprecation warnings running packageurl-php. The deprecation warnings were getting written to stdout (I guess that's useful if PHP is running as CGI…) which is supposed to be lines of JSON. The JSON parse error would trigger the program to exit, but the cleanup would fail and the exception from failing to cleanup would replace the exception that caused the program to exit. I suppressed the warnings, added a handler for invalid json, and added a block to ignore errors when calling communicate to cleanly close the Docker connections.
The other problem is that on my new computer I'm using Podman and Podman Machine doesn't like when I try to simultaneously run 14 commands. Apparently it's using SSH to access the control socket and there's some sort of rate limit on new connections. I was able to work around it by synchronizing the code that launches the container and adding a delay, but I don't think that's really fit to include so I didn't include any fix for that here.