-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better user interface to edit reverse DNS servers (dns.revServers
)
#2943
base: development
Are you sure you want to change the base?
Conversation
18799fe
to
64efa24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did test your PR and it looks really great overall. However, I see you moved this PR into draft mode again and I hope the reason is: because you are adding editing :-)
The first thing I noticed was my currently defined revServer cannot be disabled. The ideal solution would be having <input>
boxes in the table and allow full-blown editing (rendering the new multi-line raw value for revServers
fromt he fields on save).
This is expected... In the current state, this PR can only add and delete entries. I didn't create functions to edit fields (this checkbox is just a nice way to display true/false values).
This is in my todo list. |
043ce9d
to
da84675
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
…ield Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
This commit will be removed. Signed-off-by: RD WebDesign <[email protected]>
987f866
to
d988fdc
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: RD WebDesign <[email protected]>
Conflicts have been resolved. |
@rdwebdesign |
I completely forgot about it. I will take a look again when I find some time, but this is not necessary to v6 release. |
I agree, it'd also a nice v6.1 thing |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What does this PR aim to accomplish?
Replace the current single
<textarea>
with a table.Each reverse server will be in a separate row and each field will be in a separate table cell.
A small legend will improve usability (maybe we will need to change the help text).
NOTE:
Depends on #2885(already merged)How does this PR accomplish the above?
Using datatables plugin and a few functions to deal with dns.revServers entries.
By submitting this pull request, I confirm the following:
git rebase
)