remove unused vars + test inputs

pia-foss · Sep 25, 2024 · 26b19c2 · 26b19c2
1 parent 94d3cab
commit 26b19c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/.github/workflows/build_and_sign.yml b/.github/workflows/build_and_sign.yml
@@ -8,24 +8,12 @@ on:
       APP_BUILD_TARGET:
         required: true
         type: string
-      EXTENSION_BUILD_TARGET:
-        required: true
-        type: string
       # APP_PROVISION_PROFILE:
       #   required: true
       #   type: string
       # SEXT_PROVISION_PROFILE:
       #   required: true
       #   type: string
-      EXTENSION_ID:
-        required: true
-        type: string
-      CODESIGN_IDENTITY:
-        required: true
-        type: string
-      TEAM_ID:
-        required: true
-        type: string
     secrets:
       APPLE_DEVELOPER_ID_CERT_BASE64:
         required: true
@@ -47,6 +35,7 @@ jobs:
     env:
       PROJECT: SplitTunnelProxy
       PACKAGE_FOR_RELEASE: 1
+      EXTENSION_BUILD_TARGET: SplitTunnelProxyExtension
       APP_PROVISION_PROFILE: ${{ github.workspace }}/app.provisionprofile
       SEXT_PROVISION_PROFILE: ${{ github.workspace }}/sext.provisionprofile
     steps:
@@ -56,6 +45,8 @@ jobs:
     - uses: actions/checkout@v3
     - name: Install signing certificate
       run: |
+        echo "installing signing certificates for ${{ inputs.BRAND }}"
+
         CERTIFICATE_PATH=${{ github.workspace }}/build_certificate.p12
         KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db
 

diff --git a/.github/workflows/kape_macos_split_tunnel.yml b/.github/workflows/kape_macos_split_tunnel.yml
@@ -19,10 +19,6 @@ jobs:
     with:
       BRAND: PIA
       APP_BUILD_TARGET: PIA Split Tunnel
-      EXTENSION_BUILD_TARGET: SplitTunnelProxyExtension
-      EXTENSION_ID: com.privateinternetaccess.vpn.splittunnel
-      CODESIGN_IDENTITY: ${{ vars.PIA_CODESIGN_IDENTITY }}
-      TEAM_ID: ${{ vars.PIA_APPLE_TEAM_ID }}
 
   # build_and_sign_CG:
   #   permissions: