Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-1832: Add first snapshot test for Welcome view #156

Merged
merged 1 commit into from
Jun 10, 2024
Merged

PIA-1832: Add first snapshot test for Welcome view #156

merged 1 commit into from
Jun 10, 2024

Conversation

kp-said-rehouni
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni commented Jun 6, 2024 •
edited
Loading

Summary
This PR integrates snapshot testing for tvOS. It includes the first test for the Welcome screen and it adds the snapshot testing on CI

@kp-said-rehouni kp-said-rehouni marked this pull request as ready for review June 6, 2024 18:46
@kp-said-rehouni kp-said-rehouni force-pushed the PIA-1832_snapshot_testing_tvos branch 3 times, most recently from 1e87d97 to ac2bc23 Compare June 6, 2024 20:17
kp-geneva-parayno
kp-geneva-parayno reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@kp-geneva-parayno kp-geneva-parayno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it locally. i had to witch record: true on the first run, then it passed on the succeeding runs.

PIA VPN-tvOSTests/Snapshot/__Snapshots__/WelcomeViewSnapshotTest/testExample.1.png Outdated Show resolved Hide resolved
PIA VPNTests snapshot/PIA_VPNTests_snapshot.swift Outdated Show resolved Hide resolved
PIA VPNTests snapshot/__Snapshots__/WelcomeViewSnapshotTest/test_Welcome.1.png Show resolved Hide resolved
@kp-said-rehouni kp-said-rehouni force-pushed the PIA-1832_snapshot_testing_tvos branch from ac2bc23 to e7d8838 Compare June 10, 2024 07:50
@kp-said-rehouni kp-said-rehouni force-pushed the PIA-1832_snapshot_testing_tvos branch from e7d8838 to 6518a60 Compare June 10, 2024 07:56
kp-geneva-parayno
kp-geneva-parayno approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@kp-geneva-parayno kp-geneva-parayno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for helping out on this, Said! Thanks!

@kp-said-rehouni kp-said-rehouni merged commit f2943a1 into master Jun 10, 2024
0 of 2 checks passed
@kp-said-rehouni kp-said-rehouni deleted the PIA-1832_snapshot_testing_tvos branch June 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-geneva-parayno kp-geneva-parayno kp-geneva-parayno approved these changes

@kp-laura-sempere kp-laura-sempere Awaiting requested review from kp-laura-sempere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-said-rehouni @kp-geneva-parayno