PIA-986: Dashboard Connection Details Tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods on test screen classes
kp-geneva-parayno
requested review from
kp-laura-sempere,
kp-said-rehouni and
kp-ruth-o
kp-laura-sempere
approved these changes
Dec 18, 2023
| @@ -313,7 +314,7 @@ extension HandshakePopoverSelectionView: UITableViewDelegate, UITableViewDataSou | |||
| } | |||
|
|
|||
| func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | |||
|
|
|||
| self.accessibilityIdentifier = "HandshakePopoverSelectionView" | |||
|
|
||
| var connectionTileCell: XCUIElement { | ||
| cell(with: "ConnectionTileCollectionViewCell") | ||
| } |
There was a problem hiding this comment.
Great call adding the accesibilityIdentifiers in all those elements 👍
kp-said-rehouni
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dashboard Connection Details Tests; Optimised elements and methods on test screen classes