-
Notifications
You must be signed in to change notification settings - Fork 91
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for composite unique constraint
- Loading branch information
Showing
12 changed files
with
888 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
ca4c4a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atkei Sorry to bother you, but I think this is great. I tried this branch and everything works and looks great. Migrations work, constraints are correctly added to the database. I removed the constraints by simply deleting (or commenting out) the constraints from the table definition (hope I did it right) and that works too. I don't know if you want to add anything else, but my opinion is that you should made PR.
ca4c4a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sinisaos
Thank you for caring about me.
I'll create a PR to get feedback.
ca4c4a2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atkei No problem 😃 . I think this is great, but feedback from maintainer is most important. You probably need to write docs for this, but there is time for that if the feedback is positive. Thanks again for your effort.