Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add post event hooks #231

Closed
wants to merge 3 commits into from
Closed

Conversation

sinisaos
Copy link
Member

@sinisaos sinisaos commented May 9, 2023

Based on #210 by @ocervell with fixed linter errors and tests.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #231 (5bbfaa7) into master (92ea0ac) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   92.55%   92.63%   +0.08%     
==========================================
  Files          33       33              
  Lines        2027     2036       +9     
==========================================
+ Hits         1876     1886      +10     
+ Misses        151      150       -1     
Impacted Files Coverage Δ
piccolo_api/crud/endpoints.py 95.02% <100.00%> (+0.26%) ⬆️
piccolo_api/crud/hooks.py 93.33% <100.00%> (+0.47%) ⬆️

@sinisaos sinisaos closed this Sep 1, 2023
@sinisaos sinisaos deleted the post_event_hooks branch September 1, 2023 12:38
@JoshYuJump
Copy link
Contributor

@dantownsend Hi, I have used the code from this PR, it works fine. Do your have time to check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants