Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CSP regression #280

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Fix the CSP regression #280

merged 2 commits into from
Mar 30, 2024

Conversation

Skelmis
Copy link
Contributor

@Skelmis Skelmis commented Mar 30, 2024

The previous version made a change to the CSP which results in an incorrect CSP policy being set, which leads to it being ignored by browsers.

@dantownsend
Copy link
Member

Oops, good catch! Some tests are failing because we need to add the colon to the expected result.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (d4f6e66) to head (1645945).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          34       34           
  Lines        2053     2053           
=======================================
  Hits         1903     1903           
  Misses        150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend merged commit f6567af into piccolo-orm:master Mar 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants