In the Grid classes, only save the vectors #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Mar 14, 2022
Comment on lines
-271
to
-280
| self.nx = nx | ||
| self.xmin = xmin | ||
| self.xmax = xmax | ||
| self.bc_xmin = bc_xmin | ||
| self.bc_xmax = bc_xmax | ||
| self.xmin_particles = xmin_particles | ||
| self.xmax_particles = xmax_particles | ||
| self.bc_xmin_particles = bc_xmin_particles | ||
| self.bc_xmax_particles = bc_xmax_particles | ||
|
|
There was a problem hiding this comment.
Do you want to add @property for those to make them backwards compatible for users?
There was a problem hiding this comment.
clarified on slack: backwards compatibility is not needed at this point, we want to move fast and enhance/modernize things
RemiLehe
approved these changes
Mar 14, 2022
|
Thanks for this PR @dpgrote. It seems that there is a small conflict ; could you fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Grid classes, the user can specify either the individual attributes (such as nx, ny, and nz) or can specify a vector of values (as in number_of_cells). This PR changes the internals so that only the vectors are saved. This avoids the possibility of having the two different values being inconsistent.
This is a change in the internals of PICMI and will affect implementations (it is not backwards compatible). The implementation will need to use the vectors to access the user input parameters.
I note that FBPIC will need to be updated.
First spotted in #60
Note that when changing to the data class scheme, this PR becomes moot.