Use the accept language parameter #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if there is anything that i'm missing! |
|
I cannot find in the documentation why this is needed and how it works. Can you show me what this is for? |
In this endpoint for example: https://api.bol.com/retailer/public/redoc/v10/retailer.html#tag/Product-Content/operation/get-catalog-product. It expects the language as an header. And it was possible in this package to pass the language as an parameter, but this parameter is never used now. |
|
Gotcha, thanks. Seems like it was only half-supported before. |
|
Included in this release: https://github.com/picqer/bol-retailer-php-client/releases/tag/v10.2.2 |
WoutervanderLoopNL
added a commit
to WoutervanderLoopNL/bol-retailer-php-client
that referenced
this pull request
Sep 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $AcceptLanguage parameter didn't get used. So I updated the generator and the baseClient to use the parameter.