Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request PID 5284 for nRFMicro #969

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Request PID 5284 for nRFMicro #969

merged 8 commits into from
Sep 11, 2024

Conversation

joric
Copy link
Contributor

@joric joric commented Sep 8, 2024

The project (https://github.com/joric/nrfmicro) was pretty popular for a while (1.4k stars currently). Going to have an official bootloader.

@pdcook
Copy link

pdcook commented Sep 8, 2024

Bootloader is a variant of Adafruit's which requires VID/PID for official integration in their library. PR here: adafruit/Adafruit_nRF52_Bootloader#342. MIT License.

Arduino core for this board is coming soon

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the bootloader PR from your repo because that's the software that will use this PID. You can follow up with requests for other firmware (Arduino and CircuitPython) too.

1209/5284/index.md Outdated Show resolved Hide resolved
@joric joric requested a review from tannewt September 9, 2024 21:30
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description back.

1209/5284/index.md Show resolved Hide resolved
@joric joric requested a review from tannewt September 11, 2024 00:05
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions are useful and I'd like to see them going forwards. I thought you'd add a note that it was for the bootloader in the description. You can do that in a follow up if you want.

@tannewt tannewt merged commit e5fd574 into pidcodes:master Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants