Initial implementation for a Compounding function #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantop114
reviewed
Dec 20, 2021
| function compound(Claim memory _claim) public notLocked { | ||
| _verifyAndMarkClaimed(_claim); | ||
|
|
||
| (, int256 price, , uint256 timeStamp, ) = priceFeed.latestRoundData(); |
There was a problem hiding this comment.
should we check for pricefeed activity before pulling prices?
something like checking if the oracle is working as expected
| function setTimelock(address _timelock) external onlyOwner | ||
| { | ||
| sharesTimeLock = ISharesTimeLock(_timelock); | ||
| emit TimelockUpdated(address(_timelock)); |
There was a problem hiding this comment.
Suggested change
| emit TimelockUpdated(address(_timelock)); | |
| emit TimelockUpdated(_timelock); |
| function setDoughReserve(address _doughReserve) external onlyOwner | ||
| { | ||
| doughReserve = _doughReserve: | ||
| emit DoughReserveUpdated(address(_doughReserve)); |
There was a problem hiding this comment.
Suggested change
| emit DoughReserveUpdated(address(_doughReserve)); | |
| emit DoughReserveUpdated(_doughReserve); |
| event TimelockUpdated(address newTimelock); | ||
| event DoughReserveUpdated(address newDoughReserve); | ||
| event DoughUpdated(address newDough); | ||
| event Compounded(uint256 sliceAmount, uint256 oraclePrice); |
There was a problem hiding this comment.
Suggested change
| event Compounded(uint256 sliceAmount, uint256 oraclePrice); | |
| event Compounded(uint256 sliceAmount, uint256 oraclePrice); | |
| event PriceOracleUpdate(address oracle); |
Comment on lines
+175
to
+178
| function setSliceVeDoughOracle(uint256 _sliceVedoughOracle) external onlyOwner { | ||
| IAggregatorV3Interface priceFeed = IAggregatorV3Interface(_sliceVedoughOracle); | ||
| TODO emit | ||
| } |
There was a problem hiding this comment.
Suggested change
| function setSliceVeDoughOracle(uint256 _sliceVedoughOracle) external onlyOwner { | |
| IAggregatorV3Interface priceFeed = IAggregatorV3Interface(_sliceVedoughOracle); | |
| TODO emit | |
| } | |
| function setSliceVeDoughOracle(address _sliceVedoughOracle) external onlyOwner { | |
| IAggregatorV3Interface priceFeed = IAggregatorV3Interface(_sliceVedoughOracle); | |
| emit PriceOracleUpdate(_sliceVedoughOracle); | |
| } |
| IERC20(dough).safeTransferFrom(doughReserve, address(this), amountConverted); | ||
| // TODO consider have separate approval | ||
| IERC20(dough).safeApprove(address(sharesTimeLock), 0); | ||
| IERC20(dough).safeApprove(address(sharesTimeLock), amountConverted); |
There was a problem hiding this comment.
should be safe to only approve amountConverted..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.