-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): initialize default model #129
Conversation
An issue occurred related to This error occurred during https://github.com/pie-framework/pie-elements/pull/121/files merge. As a workaround I installed a new dev dependency
If you think this workaround is the right way to do it, I can submit a pull request with the fix. |
Another issue that I found is one related to the By default, In this case I suggest to use The changes will be made into https://www.dropbox.com/s/l7gzt2gef0rzaqx/Screenshot%202019-03-12%2015.30.14.png?dl=0 Is this the right approach? |
@sergiulucaci - re extended-text-entry build - yes add this to the root level babel config - thanks |
@sergiulucaci re inputComp error ... inputComponent={
inputComponent === null || inputComponent === undefined
? undefined
: inputComponent
} would work? |
Yeah Would you like to have the conditional under a |
i don't mind @sergiulucaci whatever you think reads best |
…ork/pie-elements into feat/initialize-default-model
This PR aims to resolve #124 ticket.
Default config initialization lives in a static method and the default properties are the minimum required for the UI to display and function properly.
Both config and controller methods are called
createDefaultConfig()
and default properties can be overwritten by passing themodel
as a parameter.Note: I replaced the previous branch called:
chore/elements-model-initialization
with this one in order to have a cleaner commit history.