Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ECR): fix disable/enable spanish input for student view PD-4686 #2373

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dianagociu
Copy link
Collaborator

Copy link
Contributor

@CarlaCostea CarlaCostea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dianagociu, could this change potentially cause unintended updates? It seems the model might repeatedly update with the same configuration

@dianagociu
Copy link
Collaborator Author

@CarlaCostea, The previous condition was never true because responseAreaInputConfiguration.inputConfiguration.characters.disabled gets modified as soon as the toggle is switched. Consequently, I removed the condition to ensure the model updates properly. Repeated updates with the same configuration won't occur because the toggles ensure the method is triggered only when switched, resulting in a different value each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants