[feat] 동시성 문제 해결하기 (#83)

* feat #82 : 동시성 문제 해결하기 * test #82 : 동시성 문제 해결 테스트 * refactor #82 : 필요없는 if문 삭제 및 불필요한 변수 할당 제거 * docs #82 : 스키마 변경
pie2457 · Jan 3, 2024 · 9e8b83d · 9e8b83d
1 parent 6654501
commit 9e8b83d
Show file tree

Hide file tree

Showing 4 changed files with 141 additions and 285 deletions.
diff --git a/src/main/java/pie/tomato/tomatomarket/application/item/ItemService.java b/src/main/java/pie/tomato/tomatomarket/application/item/ItemService.java
@@ -109,10 +109,9 @@ private void updateImages(List<MultipartFile> itemImages, Item findItem) {
 		if (itemImages == null || itemImages.isEmpty()) {
 			return;
 		}
-		if (!itemImages.isEmpty()) {
-			List<String> updateImageUrls = imageService.uploadImagesToS3(itemImages);
-			imageRepository.saveAllImages(Image.createImage(updateImageUrls, findItem));
-		}
+
+		List<String> updateImageUrls = imageService.uploadImagesToS3(itemImages);
+		imageRepository.saveAllImages(Image.createImage(updateImageUrls, findItem));
 	}
 
 	private String updateThumbnail(Item item, String thumbnailUrl, MultipartFile thumbnail) {
@@ -170,8 +169,9 @@ private void verifyExistsItem(Long itemId) {
 		}
 	}
 
+	@Transactional
 	public ItemDetailResponse itemDetails(Principal principal, Long itemId) {
-		Item findItem = itemRepository.findById(itemId)
+		Item findItem = itemRepository.findByIdWithPessimisticLock(itemId)
 			.orElseThrow(() -> new NotFoundException(ErrorCode.NOT_FOUND_ITEM));
 
 		itemViewCountRedisService.addViewCount(principal.getNickname(), itemId);

diff --git a/src/main/java/pie/tomato/tomatomarket/infrastructure/persistence/item/ItemRepository.java b/src/main/java/pie/tomato/tomatomarket/infrastructure/persistence/item/ItemRepository.java
@@ -4,7 +4,12 @@
 
 import java.util.Optional;
 
+import javax.persistence.LockModeType;
+
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Lock;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
 
 import com.querydsl.core.types.dsl.BooleanExpression;
 
@@ -15,6 +20,10 @@ public interface ItemRepository extends JpaRepository<Item, Long> {
 
 	Optional<Item> findByIdAndMemberId(Long itemId, Long memberId);
 
+	@Lock(LockModeType.PESSIMISTIC_WRITE)
+	@Query("select item from Item item where item.id = :itemId")
+	Optional<Item> findByIdWithPessimisticLock(@Param("itemId") Long itemId);
+
 	boolean existsItemById(Long itemId);
 
 	default BooleanExpression lessThanItemId(Long itemId) {